Re: [PATCH 7/7] openrisc: remove the redundant of_platform_populate

From: Jonas Bonn
Date: Mon Sep 19 2016 - 10:32:19 EST

On 09/16/2016 04:43 PM, Stafford Horne wrote:
From: Rob Herring <robh@xxxxxxxxxx>

The of_platform_populate call in the openrisc arch code is now redundant
as the DT core provides a default call. Openrisc has a NULL match table
which means only top level nodes with compatible strings will have
devices creates. The default version will also descend nodes in the
match table such as "simple-bus" which should be fine as openrisc
doesn't have any of these (though it is preferred that memory-mapped
peripherals be grouped under a bus node(s)).

Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
Cc: Jonas Bonn <jonas@xxxxxxxxxxxx>
Signed-off-by: Stafford Horne <shorne@xxxxxxxxx>

Yes, this is fine, but trivial/generic stuff like this doesn't really need to go via the OpenRISC repo, anyway.


arch/openrisc/kernel/setup.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
index b4ed8b3..d2f78cf 100644
--- a/arch/openrisc/kernel/setup.c
+++ b/arch/openrisc/kernel/setup.c
@@ -38,7 +38,6 @@
#include <linux/of.h>
#include <linux/memblock.h>
#include <linux/device.h>
-#include <linux/of_platform.h>
#include <asm/sections.h>
#include <asm/segment.h>
@@ -219,15 +218,6 @@ void __init or32_early_setup(void *fdt)
-static int __init openrisc_device_probe(void)
- of_platform_populate(NULL, NULL, NULL, NULL);
- return 0;
static inline unsigned long extract_value_bits(unsigned long reg,
short bit_nr, short width)