Re: [PATCH] ovl: avoid setting uninitialized creds

From: Miklos Szeredi
Date: Mon Sep 19 2016 - 10:53:34 EST

On Mon, Sep 19, 2016 at 2:38 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> If the call to ovl_copy_up() fails, we now call revert_creds on
> an uninitialized structure after a recent patch, as found
> by "gcc -Wmayby-uninitialized":
> fs/overlayfs/inode.c: In function 'ovl_open_maybe_copy_up':
> fs/overlayfs/inode.c:39:2: error: 'old_cred' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> fs/overlayfs/inode.c:22:21: note: 'old_cred' was declared here
> This changes the code back to not call revert_creds unless
> we have already called ovl_override_creds().

Thanks. Slightly reworked fix folded into original patch and pushed out.