Re: [PATCH 2/6] kvm: x86: drop read_tsc_offset()

From: Paolo Bonzini
Date: Mon Sep 19 2016 - 11:34:44 EST

On 19/09/2016 17:30, Jim Mattson wrote:
> vmx_read_tsc_offset has a bug when running nested VMs. It should really be:
> if (is_guest_mode(vcpu))
> return to_vmx(vcpu)->nested.vmcs01_tsc_offset;
> else
> return vmcs_read64(TSC_OFFSET);
> Perhaps a better name woulf be "vmx_get_l1_tsc_offset."

I agree, but doesn't this patch fix the bug too?


> In any case, this does not seem consistent with vcpu->arch.tsc_offset.

Attachment: signature.asc
Description: OpenPGP digital signature