Re: [PATCH 1/2] power: bq27xxx_battery: add configurable poll_interval by sysfs

From: Sebastian Reichel
Date: Mon Sep 19 2016 - 15:46:14 EST


On Fri, Sep 16, 2016 at 08:42:54PM -0700, Matt Ranostay wrote:
> Allow the poll_interval to be runtime configurable via an sysfs
> entry. This is needed for udev control of the poll interval.
> Signed-off-by: Matt Ranostay <matt@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/power/supply/bq27xxx_battery.c | 48 +++++++++++++++++++++++++++++++++-
> 1 file changed, 47 insertions(+), 1 deletion(-)

New sysfs attributes should be documented in Documentation/ABI.

Also I'm not too keen to add this, as there is already the sysfs
entry for the module parameter. I don't see any reason why udev
should not be able to change that value, so fix udev instead of
duplicating functionality in the kernel.

-- Sebastian

Attachment: signature.asc
Description: PGP signature