Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

From: Dan Carpenter
Date: Tue Sep 20 2016 - 04:53:10 EST


On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote:
> > Being over zealous in removing unused EXPORT_SYMBOLs two functions
> > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be
> > exported so this patch restores those EXPORT_SYMBOLS. Same mistake
> > was done when porting to the upstream client.
>
> How did our build testing not catch this? What needs these exports? Is
> it any in-kernel code?
>
> confused,

It did catch it... James, every patch has to be buildable (bisectable)
so the original patch is never going to be merged.

regards,
dan carpenter