Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md

From: James Simmons
Date: Tue Sep 20 2016 - 11:18:16 EST

> > On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote:
> > > Being over zealous in removing unused EXPORT_SYMBOLs two functions
> > > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be
> > > exported so this patch restores those EXPORT_SYMBOLS. Same mistake
> > > was done when porting to the upstream client.
> >
> > How did our build testing not catch this? What needs these exports? Is
> > it any in-kernel code?
> >
> > confused,
> It did catch it... James, every patch has to be buildable (bisectable)
> so the original patch is never going to be merged.

We missed it original as well due to the fact it showed up on only
specific platforms. I have no idea why that is. The majority of the
time it works. BTW is there a way to run kbuild bot on a patch set
before submission to avoid these corner cases.