Re: [PATCH 1/2 v2] drivers/base: Combine topology.c and cpu.c

[kbuild test robot]

Hi Prarit,

[auto build test ERROR on driver-core/driver-core-testing]
[also build test ERROR on v4.8-rc7 next-20160920]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Prarit-Bhargava/cpu-hotplug-Preserve-topology-directory-after-soft-remove-event/20160920-233904
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All error/warnings (new ones prefixed by >>):

   In file included from arch/sparc/include/asm/topology.h:4:0,
                    from include/linux/topology.h:35,
                    from include/linux/gfp.h:8,
                    from include/linux/kmod.h:22,
                    from include/linux/module.h:13,
                    from drivers/base/cpu.c:6:
   drivers/base/cpu.c: In function 'physical_package_id_show':
>> arch/sparc/include/asm/topology_64.h:44:44: error: implicit declaration of function 'cpu_data' [-Werror=implicit-function-declaration]
    #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
                                               ^
>> drivers/base/cpu.c:188:30: note: in expansion of macro 'topology_physical_package_id'
     return sprintf(buf, "%d\n", topology_##name(dev->id)); \
                                 ^~~~~~~~~
>> drivers/base/cpu.c:210:1: note: in expansion of macro 'define_id_show_func'
    define_id_show_func(physical_package_id);
    ^~~~~~~~~~~~~~~~~~~
>> arch/sparc/include/asm/topology_64.h:44:57: error: request for member 'proc_id' in something not a structure or union
    #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
                                                            ^
>> drivers/base/cpu.c:188:30: note: in expansion of macro 'topology_physical_package_id'
     return sprintf(buf, "%d\n", topology_##name(dev->id)); \
                                 ^~~~~~~~~
>> drivers/base/cpu.c:210:1: note: in expansion of macro 'define_id_show_func'
    define_id_show_func(physical_package_id);
    ^~~~~~~~~~~~~~~~~~~
   drivers/base/cpu.c: In function 'core_id_show':
>> arch/sparc/include/asm/topology_64.h:45:47: error: request for member 'core_id' in something not a structure or union
    #define topology_core_id(cpu)   (cpu_data(cpu).core_id)
                                                  ^
>> drivers/base/cpu.c:188:30: note: in expansion of macro 'topology_core_id'
     return sprintf(buf, "%d\n", topology_##name(dev->id)); \
                                 ^~~~~~~~~
   drivers/base/cpu.c:213:1: note: in expansion of macro 'define_id_show_func'
    define_id_show_func(core_id);
    ^~~~~~~~~~~~~~~~~~~
>> drivers/base/cpu.c:186:10: warning: control reaches end of non-void function [-Wreturn-type]
      struct device_attribute *attr, char *buf) \
             ^
   drivers/base/cpu.c:213:1: note: in expansion of macro 'define_id_show_func'
    define_id_show_func(core_id);
    ^~~~~~~~~~~~~~~~~~~
   drivers/base/cpu.c: In function 'physical_package_id_show':
>> drivers/base/cpu.c:186:10: warning: control reaches end of non-void function [-Wreturn-type]
      struct device_attribute *attr, char *buf) \
             ^
>> drivers/base/cpu.c:210:1: note: in expansion of macro 'define_id_show_func'
    define_id_show_func(physical_package_id);
    ^~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/core_id +45 arch/sparc/include/asm/topology_64.h

f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  38  
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  39  #include <asm-generic/topology.h>
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  40  
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  41  #endif /* !(CONFIG_NUMA) */
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  42  
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  43  #ifdef CONFIG_SMP
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17 @44  #define topology_physical_package_id(cpu)	(cpu_data(cpu).proc_id)
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17 @45  #define topology_core_id(cpu)			(cpu_data(cpu).core_id)
acc455cf arch/sparc/include/asm/topology_64.h chris hyser         2015-04-22  46  #define topology_core_cpumask(cpu)		(&cpu_core_sib_map[cpu])
06931e62 arch/sparc/include/asm/topology_64.h Bartosz Golaszewski 2015-05-26  47  #define topology_sibling_cpumask(cpu)		(&per_cpu(cpu_sibling_map, cpu))
f5e706ad include/asm-sparc/topology_64.h      Sam Ravnborg        2008-07-17  48  #endif /* CONFIG_SMP */

:::::: The code at line 45 was first introduced by commit
:::::: f5e706ad886b6a5eb59637830110b09ccebf01c5 sparc: join the remaining header files

:::::: TO: Sam Ravnborg <sam@xxxxxxxxxxxx>
:::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip