Re: [PATCH 5/6] GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data()

From: Patrik Jakobsson
Date: Tue Sep 20 2016 - 16:23:23 EST

On Tue, Sep 20, 2016 at 2:08 PM, Jani Nikula
<jani.nikula@xxxxxxxxxxxxxxx> wrote:
> On Tue, 20 Sep 2016, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>> Don't be a dummy... This is easy to review an it fixes a bug.

In this particular case it might not be clear that an unknown GCT
version causes a complete GCT failure so both messages are useful.

>> I'm fine with you NAKing all these patches based on who they are from.
>> I mostly just delete these without responding because the guy has
>> history of introducing bugs and never listens to feedback. But asking
>> pointless rhetorical questions is not helpful.
>> A lot of people are CC'd and you're wasting everyone's time by asking
>> questions where you know the answer.
> Fair enough, sorry for the noise.
> To be honest, I did only look at the patches, not who they were from. We
> have CI for drm/i915, but I don't think it's constructive to keep
> changing drivers like this where the upstream isn't actively developed
> and tested. But I digress. It's up to Patrik anyway.

Nothing in this series is very helpful so NAK. In general I'm not fond
of trivial changes like this since it's hard to say what motivates the
author. In theory it shouldn't matter but so far it's been directly
related to the quality of the patches. I can help test changes for
gma500 if needed but please make it worth my while.

Best regards

> BR,
> Jani.
> --
> Jani Nikula, Intel Open Source Technology Center