[tip:perf/core] perf symbols: Do not open device files

From: tip-bot for Jiri Olsa
Date: Tue Sep 20 2016 - 17:46:15 EST

Commit-ID: 3c028a0cb5b71f47d523bc8ad2c597cb257f41fb
Gitweb: http://git.kernel.org/tip/3c028a0cb5b71f47d523bc8ad2c597cb257f41fb
Author: Jiri Olsa <jolsa@xxxxxxxxxx>
AuthorDate: Tue, 20 Sep 2016 18:12:45 +0200
Committer: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
CommitDate: Tue, 20 Sep 2016 16:20:21 -0300

perf symbols: Do not open device files

The dso__read_binary_type_filename gets the dso's file name to open. We
need to check it for regular file before trying to open it, otherwise we
might get stuck with device file.

Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxx>
Cc: Don Zickus <dzickus@xxxxxxxxxx>
Cc: Joe Mario <jmario@xxxxxxxxxx>
Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Link: 20160920161245.GA8995@krava">http://lkml.kernel.org/r/20160920161245.GA8995@krava
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
tools/perf/util/dso.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 774f6ec..d2c6cdd 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -363,6 +363,9 @@ static int __open_dso(struct dso *dso, struct machine *machine)
return -EINVAL;

+ if (!is_regular_file(name))
+ return -EINVAL;
fd = do_open(name);
return fd;