Re: [PATCH 1/9] x86/entry/head/32: use local labels

From: Josh Poimboeuf
Date: Tue Sep 20 2016 - 22:52:36 EST

On Tue, Sep 20, 2016 at 05:57:16PM -0700, Andy Lutomirski wrote:
> On Sep 20, 2016 10:03 AM, "Josh Poimboeuf" <jpoimboe@xxxxxxxxxx> wrote:
> >
> > Add the local label prefix to all non-function named labels in head_32.S
> > and entry_32.S. In addition to decluttering the symbol table, it also
> > will help stack traces to be more sensible. For example, the last
> > reported function in the idle task stack trace will be startup_32_smp()
> > instead of is486().
> >
> I think that restore_all, at least, should stay. It's a common tail
> for lots of functions. I haven't checked this patch for other cases
> where the new label is worse than the old for debugging.

Yes, for restore_all, I think you're right. I'll change it back.