Re: [PATCH] mtd: spi-nor: Add support for S3AN spi-nor devices

From: Ricardo Ribalda Delgado
Date: Wed Sep 21 2016 - 04:26:52 EST


>> Unsinged long is more than enough for s3an. I think v7 is ok.
> Then, why did you change the spi_nor_s3an_addr_convert() prototype?

Because it is used in spi_nor_read and spi_nor_write, which use loff_t.

I think it is more clean to have only one comment explaining the max
size of the s3an, instead of having them scattered around. But if
think that it is better to have unsinged int as prototype I have no
problem in changing it.


Ricardo Ribalda