Re: [PATCH] HID: alps: fix stick device not working after resume
From: Kai Heng Feng
Date: Thu Sep 22 2016 - 01:12:24 EST
On Wed, Sep 21, 2016 at 8:00 PM, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
> On Mon, 19 Sep 2016, Kai Heng Feng wrote:
>
>> >> The stick device does not work after resume, add U1_SP_ABS_MODE flag can
>> >> make the device work after resume.
>> >
>> > Do you happen to have any more details on why it doesn't work without
>> > U1_SP_ABS_MODE? Or was this a pure guesswork?
>>
>> It' pure guesswork, based on how the existing code uses U1_TP_ABS_MODE flag
>> on both initialization and resume.
>>
>> I also tested the the patch on an ALPS touchpad without stick device,
>> did not notice
>> any side effect on suspend/resume, so I made the U1_SP_ABS_MODE flag mandatory.
>
> I'll fold this information into the patch changelog before comitting; if
> you disagree, please let me know.
That will be great.
Appreciate!
>
> --
> Jiri Kosina
> SUSE Labs
>