Re: [PATCH 1/2] jump_labels: Add API to deal with keys embedded in structures

From: Peter Zijlstra
Date: Thu Sep 22 2016 - 03:47:54 EST

On Tue, Sep 20, 2016 at 02:54:01PM +0200, Christoffer Dall wrote:
> On Tue, Sep 20, 2016 at 02:42:58PM +0200, Peter Zijlstra wrote:
> > 'struct static_key' should indeed not be used and is deprecated. 'struct
> > static_key_{true,false}' however should be fine.
> ah, ok, didn't realize this, especially since static_key_false() is also
> listed as deprecated ;)

Yeah, that's one of the horribly badly named things we wants to get rid
of :-) But note, its a function not a type.

> > Part of the problem is naming, everything using 'struct static_key' has
> > _insane_ names and the API is utterly confusing. The other part is that
> > the new 2 type API simply has more functionality.
> right, ok. As long as you're happy with slightly increased use of
> directly embeddeing struct static_key_{true,false}, we're good.
> Sorry for both if I encouraged confusion here.

No problem, jump_labels have been cursed with confusion.