Re: [PATCH] drm/i2c: tda998x: don't register the connector
From: Sean Paul
Date: Thu Sep 22 2016 - 08:33:11 EST
On Thu, Sep 22, 2016 at 5:09 AM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxx> wrote:
> On Thu, Sep 22, 2016 at 04:22:40AM -0700, Sean Paul wrote:
>> On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux
>> <linux@xxxxxxxxxxxxxxx> wrote:
>> > On Thu, Sep 22, 2016 at 11:39:18AM +0100, Brian Starkey wrote:
>> >> Actually, could you please hold off picking this up? We need to make
>> >> changes in mali-dp and hdlcd or this will mess up their registration.
>> >> I will send those patches later today, but better if this all goes in
>> >> together (whenever that ends up being).
>> >
>> > Sorry, but I'm annoyed with this - the impression being given was that
>> > I was holding up this patch by not testing it on Armada, and I brought
>> > up the issue about registration at the beginning of this.
>> >
>> > Now we're _just_ finding out that there are drivers where removing the
>> > connector registration in tda998x causes them to break? It's a bit
>> > late to be checking your own drivers when you've been chasing me...
>> >
>> > Sorry, but it sounds like we're not ready to make this change - and as
>> > it's the very last day that changes will appear in linux-next prior to
>> > the merge window (assuming Linus releases 4.8 on Sunday), I'd suggest
>> > holding off until after the merge window is over, so we can get some
>> > testing with these other two drivers with this change in place.
>> >
>>
>> sigh. I just pushed my queue to drm-misc, which included this patch.
>> Sounds like I should revert?
>
> Why did you do push it _without_ an ack from the maintainer of the
> driver when the comments on the list were clearly indicating that it
> was waiting for testing and such an ack?
>
Daniel Acked it on the list on 7/25, and you acked it yesterday asking
it to be merged to -misc. What am I missing?
Sean
> There's something horribly wrong with the process here.
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
> according to speedtest.net.