Re: [PATCH v4 10/10] cpufreq: intel_pstate: Use CPPC to get max performance

From: Thomas Gleixner
Date: Thu Sep 22 2016 - 14:58:51 EST


On Thu, 22 Sep 2016, Tim Chen wrote:
> On Wed, 2016-09-21 at 22:30 +0200, Rafael J. Wysocki wrote:
> > My current understanding is that we need to rebuild sched domains
> > after setting the priorities,
>
> No, that's not true. ÂWe need to rebuild the sched domains only
> when the sched domain flags are changed, not when we are changing
> the priorities. ÂOnly the sched domain flag is a property of
> the sched domain. CPU priority values are not part of sched domain.
>
> Morten had similar question about whether we need to rebuild sched domain
> when we change cpu priorities when we first post the patches.Â
> Peter has explained that it wasn't necessary.
> http://lkml.iu.edu/hypermail/linux/kernel/1608.3/01753.html

And why is there no explanation in form of a comment in the code?

Thanks,

tglx