Re: [PATCH v4 07/10] x86/sched: Add SD_ASYM_PACKING flags to x86 ITMT CPU

[Tim Chen]

On Wed, 2016-09-21 at 22:33 +0200, Rafael J. Wysocki wrote:
> On Wed, Sep 21, 2016 at 9:19 PM, Srinivas Pandruvada
> <srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote:
> > 
> > From: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> > 
> > Some Intel cores in a package can be boosted to a higher turbo frequency
> > with ITMT 3.0 technology. The scheduler can use the asymmetric packing
> > feature to move tasks to the more capable cores.
> > 
> > If ITMT is enabled, add SD_ASYM_PACKING flag to the thread and core
> > sched domains to enable asymmetric packing.
> > 
> > Signed-off-by: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > ---
> > Âarch/x86/kernel/smpboot.c | 27 +++++++++++++++++++++++----
> > Â1 file changed, 23 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> > index 38901b3..46815e6 100644
> > --- a/arch/x86/kernel/smpboot.c
> > +++ b/arch/x86/kernel/smpboot.c
> > @@ -487,22 +487,41 @@ static bool match_die(struct cpuinfo_x86 *c, struct cpuinfo_x86 *o)
> > ÂÂÂÂÂÂÂÂreturn false;
> > Â}
> > 
> > +#ifndef CONFIG_SCHED_ITMT
> > +#define sysctl_sched_itmt_enabledÂÂÂÂÂÂ0
> > +#endif
> I thought that would be done in the header where
> sysctl_sched_itmt_enabled is declared (along with defining the stubs
> for the sched_set_itmt_* functions).

Sure. I will move it toÂarch/x86/include/asm/topology.h.

Tim