Re: [PATCH] mfd/gpio: move HTC GPIO driver to GPIO subsystem
From: Linus Walleij
Date: Fri Sep 23 2016 - 05:43:29 EST
On Tue, Sep 20, 2016 at 12:33 AM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxx> wrote:
> On Fri, Sep 16, 2016 at 01:52:50PM +0200, Linus Walleij wrote:
>> Russell/ARM SoC: heads-up and ACK request.
>
> Fine with one exception:
>
>> diff --git a/arch/arm/mach-sa1100/h3xxx.c b/arch/arm/mach-sa1100/h3xxx.c
>> index b1d4faa12f9a..75ab3b086e6f 100644
>> --- a/arch/arm/mach-sa1100/h3xxx.c
>> +++ b/arch/arm/mach-sa1100/h3xxx.c
>> @@ -14,7 +14,7 @@
>> #include <linux/gpio.h>
>> #include <linux/gpio_keys.h>
>> #include <linux/input.h>
>> -#include <linux/mfd/htc-egpio.h>
>> +#include <linux/platform_data/gpio-htc-egpio.h>
>> #include <linux/mtd/mtd.h>
>> #include <linux/mtd/partitions.h>
>> #include <linux/platform_data/sa11x0-serial.h>
>
> The includes here are arranged alphabetically with the exception of
> linux/kernel.h, as per commit 4aa975558065 ("ARM: 5822/1: SA1100:
> h3100/h3600: clean up #includes") - please keep them alphabetical.
Sorry about that. Fixing up and providing the branch.
Yours,
Linus Walleij