Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible
From: Greg KH
Date: Fri Sep 23 2016 - 13:10:26 EST
On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:172:5: warning: no previous prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Does not apply cleanly, are you sure you are using the latest tree?
Can you fix it up and resend?
thanks,
greg k-h