Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for pcpu_embed_first_chunk()

[Tejun Heo]

Hello,

On Sat, Sep 24, 2016 at 05:16:56AM +0800, zijun_hu wrote:
> On 2016/9/24 3:23, Tejun Heo wrote:
> > On Sat, Sep 24, 2016 at 02:20:24AM +0800, zijun_hu wrote:
> >> From: zijun_hu <zijun_hu@xxxxxxx>
> >>
> >> correct max_distance from (base of the highest group + ai->unit_size)
> >> to (base of the highest group + the group size)
> >>
> >> Signed-off-by: zijun_hu <zijun_hu@xxxxxxx>
> > 
> > Nacked-by: Tejun Heo <tj@xxxxxxxxxx>
> > 
> > Thanks.
> >
> frankly, the current max_distance is error, doesn't represents the ranges spanned by
> areas owned by the groups

I think you're right but can you please update the patch description
so that it explains what the bug and the implications are and how the
patch fixes the bug.  Also, please make sure that all changes made by
the patch are explained in the description - e.g. why the type of
@max_distance is changed from size_t to ulong.

Thanks.

-- 
tejun