Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages
From: Larry Finger
Date: Sat Sep 24 2016 - 12:35:09 EST
On 09/24/2016 11:15 AM, Joe Perches wrote:
On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote:
Would it make sense to explicitly set the enum values, or add them as
comments, to make such look-ups easier?
If you want to create enum->#ENUM structs and
"const char *" lookup functions, please be my guest.
otherwise, hex is at least a consistent way to display
what should be infrequent output.
Displaying those values as hex is OK. As Joe says, they will not be shown very
often.
I have patches that makes HAL_DEF_WOWLAN be a no-op for the rest of the drivers,
and one that sets the enum values for that particular statement to hex values. I
also looked at the other large enums and decided that they never need the human
lookup.
Larry