Re: [PATCH] staging: sm750fb: rename getChipType to get_chip_type
From: Moshe Green
Date: Sat Sep 24 2016 - 17:09:48 EST
On Fri, Sep 23, 2016 at 02:13:52PM +0200, Greg KH wrote:
> On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote:
> > Rename CamelCased function getChipType to get_chip_type.
> > This issue was found by checkpatch.pl
>
> As this is a global function, can you rename it to something like
> "sm750_get_chip_type()"? Having a driver-specific function called
> get_chip_type() is not good.
>
> thanks,
>
> greg k-h
Will do.
Thanks,
Moshe Green