Re: [PATCH] ixgbe: mark symbols static where possible

From: Jeff Kirsher
Date: Sun Sep 25 2016 - 18:22:28 EST

On Sun, 2016-09-25 at 14:03 +0800, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning: no
> previous prototype for 'ixgbe_led_on_t_x550em' [-Wmissing-prototypes]
> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning: no
> previous prototype for 'ixgbe_led_off_t_x550em' [-Wmissing-prototypes]
> In fact, these two functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>
> ---
> Âdrivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++--
> Â1 file changed, 2 insertions(+), 2 deletions(-)

This has been fixed and pushed upstream, why do you keep submitting this?

Attachment: signature.asc
Description: This is a digitally signed message part