Re: [PATCH 3/6] isdn/hisax: add function declarations
From: Arnd Bergmann
Date: Sun Sep 25 2016 - 19:35:33 EST
On Sunday 25 September 2016, Baoyou Xie wrote:
> > > @@ -1350,3 +1350,63 @@ static inline struct pci_dev
> > *hisax_find_pci_device(unsigned int vendor,
> > > }
> > >
> > > #endif
> > > +
> > > +#if CARD_TELES3
> > > +int setup_teles3(struct IsdnCard *card);
> > > +#endif
> > > +
> > > +#if CARD_TELESPCI
> > > +int setup_telespci(struct IsdnCard *card);
> > > +#endif
> > > +
> >
> > When you add the declarations here, just leave out the #if guards,
> > and put all the declarations here unconditionally, as we normally
> > do in the kernel.
> >
> > oh, in this case, we can leave the declarations out the #if guards.
> but I suggest we don't do that still, cause of some declarations used by
> function parameters may reply on the macro.
They all have the same 'struct IsdnCard' argument, which is already
visible (otherwise none of them would work).
Arnd