Re: [PATCH] brcmfmac: implement more accurate skb tracking

From: RafaÅ MiÅecki
Date: Mon Sep 26 2016 - 08:38:50 EST

On 26 September 2016 at 14:13, RafaÅ MiÅecki <zajec5@xxxxxxxxx> wrote:
> On 26 September 2016 at 13:46, Arend Van Spriel
> <arend.vanspriel@xxxxxxxxxxxx> wrote:
>> On 26-9-2016 12:23, RafaÅ MiÅecki wrote:
>>> From: RafaÅ MiÅecki <rafal@xxxxxxxxxx>
>>> We need to track 802.1x packets to know if there are any pending ones
>>> for transmission. This is required for performing key update in the
>>> firmware.
>> The problem we are trying to solve is a pretty old one. The problem is
>> that wpa_supplicant uses two separate code paths: EAPOL messaging
>> through data path and key configuration though nl80211.
> Can I find it described/reported somewhere?
>>> Unfortunately our old tracking code wasn't very accurate. It was
>>> treating skb as pending as soon as it was passed by the netif. Actual
>>> handling packet to the firmware was happening later as brcmfmac
>>> internally queues them and uses its own worker(s).
>> That does not seem right. As soon as we get a 1x packet we need to wait
>> with key configuration regardless whether it is still in the driver or
>> handed over to firmware already.
> OK, thanks.

Actually, it's not OK. I was trying to report/describe/discuss this
problem for over a week. I couldn't get much of answer from you.

I had to come with a patch I worked on for quite some time. Only then
you decided to react and reply with a reason for a nack. I see this
patch may be wrong (but it's still hard to know what's going wrong
without a proper hostapd bug report). I'd expect you to somehow work &
communicate with open source community.