Re: [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag

From: Rafael J. Wysocki
Date: Mon Sep 26 2016 - 08:49:45 EST


On Wednesday, September 14, 2016 10:54:58 AM Hoan Tran wrote:
> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
> function to notify the mailbox framework about TX completion.
>
> Signed-off-by: Hoan Tran <hotran@xxxxxxx>
> Reviewed-by: Prashanth Prakash <pprakash@xxxxxxxxxxxxxx>
> ---
> drivers/acpi/cppc_acpi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 3d1ae6d..d0d0504 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -311,7 +311,10 @@ static int send_pcc_cmd(u16 cmd)
> if (pcc_data.pcc_mrtt)
> last_cmd_cmpl_time = ktime_get();
>
> - mbox_client_txdone(pcc_data.pcc_channel, ret);
> + if (pcc_data.pcc_channel->mbox->txdone_irq)
> + mbox_chan_txdone(pcc_data.pcc_channel, ret);
> + else
> + mbox_client_txdone(pcc_data.pcc_channel, ret);
>
> end:
> if (cmd == CMD_WRITE) {
>

Applied.

Thanks,
Rafael