RE: [PATCH v4] devicetree: bindings: uart: Add new compatible string for ZynqMP

[Nava kishore Manne]

> -----Original Message-----
> From: Rob Herring [mailto:robh@xxxxxxxxxx]
> Sent: Saturday, September 24, 2016 4:08 AM
> To: Nava kishore Manne <navam@xxxxxxxxxx>
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; mark.rutland@xxxxxxx; jslaby@xxxxxxxx;
> michal.simek@xxxxxxxxxx; Soren Brinkmann <sorenb@xxxxxxxxxx>; linux-
> serial@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Punnaiah
> Choudary Kalluri <punnaia@xxxxxxxxxx>; Nava kishore Manne
> <navam@xxxxxxxxxx>
> Subject: Re: [PATCH v4] devicetree: bindings: uart: Add new compatible
> string for ZynqMP
>
> On Fri, Sep 23, 2016 at 04:55:48PM +0530, Nava kishore Manne wrote:
> > From: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> >
> > This patch Adds the new compatible string for ZynqMP.
> >
> > Signed-off-by: Nava kishore Manne <navam@xxxxxxxxxx>
> > ---
> > Changes for v4:
> >             -Modified the ChangeLog comment.
> > Changes for v3:
> >             -Added changeLog comment.
> > Changes for v2:
> >                 -None
> >
> >  Documentation/devicetree/bindings/serial/cdns,uart.txt | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt
> b/Documentation/devicetree/bindings/serial/cdns,uart.txt
> > index a3eb154..4fe7aae 100644
> > --- a/Documentation/devicetree/bindings/serial/cdns,uart.txt
> > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.txt
> > @@ -1,7 +1,8 @@
> >  Binding for Cadence UART Controller
> >
> >  Required properties:
> > -- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps"
> > +- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps" for Zynq and
> > +               "cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC uart controller.
>
> Please format this as one valid combination per line.
>
> xuartps is not very specific. It needs some abbreviation of "Zynq
> Ultrascale+ MPSoC" in it.
>

Will fix the above comments in the next version.

Regards,
Navakishore.


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.