Re: [PATCH 0/2] NFS: Use complete() instead complete_all()

From: Anna Schumaker
Date: Mon Sep 26 2016 - 09:32:03 EST

On 09/26/2016 01:33 AM, Daniel Wagner wrote:
> Hi Anna,
> On 09/23/2016 03:48 PM, Anna Schumaker wrote:
>>> Besides trying to analys all the code paths to the wait_for_completion()
>>> call and convince myself that there is only one waiter, I also run
>>> a few tests:
>>> - some fio benchmarks
>>> - pynfs
>>> -cthon04
>> Thanks for the patches, and for the extensive testing! I haven't
>> tried them with xfstests yet, but They look okay to me otherwise.
>> Assuming I don't see any new failures there I'll plan on adding them
>> for v4.9.
> I tried a few tests from xfstests but I was not sure which make sense to run, that's why I went for the more NFS specific tests.
> I'll see what happens when I run the generic tests from xfstests. Should all of them pass?

No, there are a handful that we know don't pass. When I run on NFS v4.1, I get:

Failures: generic/035 generic/071 generic/128 generic/294 generic/306 generic/309 generic/310 generic/313 generic/314 generic/315 generic/316 generic/319 generic/337 generic/360 generic/375
Failed 15 of 92 tests


> cheers,
> daniel