Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get added to the state

From: Mike Lothian
Date: Mon Sep 26 2016 - 09:58:12 EST


Is there any chance this could be removed from the upcoming drm-4.9
pull, at least until this issue has been fixed



On 21 September 2016 at 12:34, Mike Lothian <mike@xxxxxxxxxxxxxx> wrote:
> I've raised I'll
> attach the info you requested once I get back to my machine
> On 21 September 2016 at 07:56, Maarten Lankhorst
> <maarten.lankhorst@xxxxxxxxxxxxxxx> wrote:
>> Hey,
>> Op 20-09-16 om 20:45 schreef Mike Lothian:
>>> Hi
>>> I've bisected back to this commit in the drm-intel-nightly branch
>>> 05a76d3d6ad1ee9f9814f88949cc9305fc165460 is the first bad commit
>>> commit 05a76d3d6ad1ee9f9814f88949cc9305fc165460
>>> Author: Lyude <cpaul@xxxxxxxxxx>
>>> Date: Wed Aug 17 15:55:57 2016 -0400
>>> drm/i915/skl: Ensure pipes with changed wms get added to the state
>>> If we're enabling a pipe, we'll need to modify the watermarks on all
>>> active planes. Since those planes won't be added to the state on
>>> their own, we need to add them ourselves.
>>> Signed-off-by: Lyude <cpaul@xxxxxxxxxx>
>>> Reviewed-by: Matt Roper <matthew.d.roper@xxxxxxxxx>
>>> Cc: stable@xxxxxxxxxxxxxxx
>>> Cc: Ville SyrjÃlà <ville.syrjala@xxxxxxxxxxxxxxx>
>>> Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx>
>>> Cc: Radhakrishna Sripada <radhakrishna.sripada@xxxxxxxxx>
>>> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
>>> Link:
>>> The symptoms I'm seeing look like tearing at the top of the screen and
>>> it's especially noticeable in Chrome - reverting this commit makes the
>>> issue go away
>>> Let me know if you'd like me to raise a bug
>> Please do so, it's nice to refer to when making a fix for it.
>> Could you attach the contents of /sys/kernel/debug/dri/0/i915_ddb_info for working and not-working in it?
>> ~Maarten