Re: [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path

From: Nikita Yushchenko
Date: Mon Sep 26 2016 - 12:15:01 EST


>> I doubt that copying 7 lines into error path is better than having a tiny
>> logic with return values, but still here it is.
>
> Consider what happens if someone wants to change the code...

I believe that "undo poweron" and "poweroff" sequences still will have
to remain the same. This having two copies of code is more error-prone
than having one.

Nikita