Re: [PATCH -v2 6/9] sched/rtmutex: Refactor rt_mutex_setprio()

[Steven Rostedt]

On Mon, 26 Sep 2016 14:32:19 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> @@ -3586,9 +3625,7 @@ void rt_mutex_setprio(struct task_struct
>  		goto out_unlock;
>  	}
>  
> -	rt_mutex_update_top_task(p);
> -
> -	trace_sched_pi_setprio(p, prio);
> +	trace_sched_pi_setprio(p, prio); /* broken */

Not a very comforting comment to see during a review ;-)

I'll hold off giving a full review of this patch while in the airport.
My mind needs a bit more "quiet" to do this one.

-- Steve

>  	oldprio = p->prio;
>  
>  	if (oldprio == prio)