Re: [lustre-devel] [PATCH] staging/lustre/lov: add missing header dependencies

From: James Simmons
Date: Mon Sep 26 2016 - 14:23:58 EST



> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]
> drivers/staging/lustre/lustre/lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]
>
> In fact, these functions are declared in ../llite/vvp_internal.h,
> so this patch add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>

Nak. I have a patch coming soon from our server code branch that removes
lov_lsm_get() and makes lov_lsm_put used only in the lov layer.
The patch is ready but I need to test it first.

> ---
> drivers/staging/lustre/lustre/lov/lov_object.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/lov/lov_object.c b/drivers/staging/lustre/lustre/lov/lov_object.c
> index f9621b0..912c416 100644
> --- a/drivers/staging/lustre/lustre/lov/lov_object.c
> +++ b/drivers/staging/lustre/lustre/lov/lov_object.c
> @@ -38,6 +38,7 @@
> #define DEBUG_SUBSYSTEM S_LOV
>
> #include "lov_cl_internal.h"
> +#include "../llite/vvp_internal.h"
>
> /** \addtogroup lov
> * @{
> --
> 2.7.4
>
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@xxxxxxxxxxxxxxxx
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>