Re: [PATCH] nvme-rdma: add missing \n to end of dev_err message

From: J Freyensee
Date: Mon Sep 26 2016 - 17:53:19 EST


On Sun, 2016-09-25 at 15:01 -0700, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Trival fix, dev_err message is missing a \n, so add it. Also
> break line as it was over 80 chars wide.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Jay Freyensee <james_p_freyensee@xxxxxxxxxxxxxxx>

> ---
> Âdrivers/nvme/host/rdma.c | 3 ++-
> Â1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 69e1fb7..3f32995 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct
> nvme_rdma_queue *queue,
> Â (struct nvme_rdma_cm_rej *)ev-
> >param.conn.private_data;
> Â
> Â dev_err(queue->ctrl->ctrl.device,
> - "Connect rejected, status %d.",
> le16_to_cpu(rej->sts));
> + "Connect rejected, status %d.\n",
> + le16_to_cpu(rej->sts));
> Â /* XXX: Think of something clever to do here... */
> Â } else {
> Â dev_err(queue->ctrl->ctrl.device,