Re: [PATCH] of: thermal: Fixed governor at each thermal zone

[Zhang Rui]

On ä, 2016-09-19 at 10:18 +0900, Inhyuk Kang wrote:
> It is necessary to be added governor at each thermal_zone.
> Because some governors should be operated in the during the kernel
> booting
> in order to avoid heating problem.
> 
> Default governor cannot be covered all thermal zones policy because
> some thermal zones want to apply different one.
> For example, the power allocator governor operates differently with
> step wise governor.
> Hence, it is better to parse governor parameter from the device tree.
> 
> Signed-off-by: Inhyuk Kang <hugh.kang@xxxxxxx>
> 
The patch looks okay to me.
Eduardo, what do you think of this patch?

thanks,
rui
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-
> thermal.c
> index b8e509c..382c440 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -970,6 +970,7 @@ int __init of_parse_thermal_zones(void)
> Â		struct thermal_zone_device *zone;
> Â		struct thermal_zone_params *tzp;
> Â		int i, mask = 0;
> +		const char *governor;
> Â		u32 prop;
> Â
> Â		tz = thermal_of_build_thermal_zone(child);
> @@ -996,6 +997,9 @@ int __init of_parse_thermal_zones(void)
> Â		if (!of_property_read_u32(child, "sustainable-
> power", &prop))
> Â			tzp->sustainable_power = prop;
> Â
> +		if (!of_property_read_string(child, "governor-name", 
> &governor))
> +			strcpy(tzp->governor_name, governor);
> +
> Â		for (i = 0; i < tz->ntrips; i++)
> Â			mask |= 1 << i;
> Â