Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

From: Kalle Valo
Date: Tue Sep 27 2016 - 07:28:10 EST

Arend Van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes:

> On 27-9-2016 11:14, RafaÅ MiÅecki wrote:
>> From: RafaÅ MiÅecki <rafal@xxxxxxxxxx>
>> Flowrings contain skbs waiting for transmission that were passed to us
>> by netif. It means we checked every one of them looking for 802.1x
>> Ethernet type. When deleting flowring we have to use freeing function
>> that will check for 802.1x type as well.
>> Freeing skbs without a proper check was leading to counter not being
>> properly decreased. This was triggering a WARNING every time
>> brcmf_netdev_wait_pend8021x was called.
> Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx>
>> Signed-off-by: RafaÅ MiÅecki <rafal@xxxxxxxxxx>
>> ---
>> Kalle: this isn't important enough for 4.8 as it's too late for that.
>> I'd like to get it for 4.9 however, as this fixes bug that could lead
>> to WARNING on every add_key/del_key call. We was struggling with these
>> WARNINGs for some time and this fixes one of two problems causing them.

Ok, I'll queue this for 4.9.

> Please mark it for stable as well.

I can add that. Any ideas how old releases stable releases should this
go to?

Kalle Valo