Re: [PATCH] of: thermal: Fixed governor at each thermal zone

[Lukasz Luba]

On 27/09/16 02:46, Zhang Rui wrote:
> On ä, 2016-09-19 at 10:18 +0900, Inhyuk Kang wrote:
> > It is necessary to be added governor at each thermal_zone.
> > Because some governors should be operated in the during the kernel
> > booting
> > in order to avoid heating problem.
> >
> > Default governor cannot be covered all thermal zones policy because
> > some thermal zones want to apply different one.
> > For example, the power allocator governor operates differently with
> > step wise governor.
> > Hence, it is better to parse governor parameter from the device tree.
> >
> > Signed-off-by: Inhyuk Kang <hugh.kang@xxxxxxx>
> The patch looks okay to me.
> Eduardo, what do you think of this patch?
Hi Rui,

Beside the fact which Javi pointed out in his email, there is an issue 
in the patch itself.
The idea behind the patch is good, but the patch should have some 
improvements, i.e:
- strncpy instead of strcpy,
- if the governor name is not found in the registered governor's list by 
__find_governor (and then null is set) we should probably switch to 
default governor,
- add DT documentation,

Regards,
Lukasz

> thanks,
> rui
> > diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-
> > thermal.c
> > index b8e509c..382c440 100644
> > --- a/drivers/thermal/of-thermal.c
> > +++ b/drivers/thermal/of-thermal.c
> > @@ -970,6 +970,7 @@ int __init of_parse_thermal_zones(void)
> >  		struct thermal_zone_device *zone;
> >  		struct thermal_zone_params *tzp;
> >  		int i, mask = 0;
> > +		const char *governor;
> >  		u32 prop;
> >
> >  		tz = thermal_of_build_thermal_zone(child);
> > @@ -996,6 +997,9 @@ int __init of_parse_thermal_zones(void)
> >  		if (!of_property_read_u32(child, "sustainable-
> > power", &prop))
> >  			tzp->sustainable_power = prop;
> >
> > +		if (!of_property_read_string(child, "governor-name",
> > &governor))
> > +			strcpy(tzp->governor_name, governor);
> > +
> >  		for (i = 0; i < tz->ntrips; i++)
> >  			mask |= 1 << i;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html