Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

From: Tilman Schmidt
Date: Tue Sep 27 2016 - 08:08:15 EST

On Tue, Sep 27, 2016, at 13:32, SF Markus Elfring wrote:
> >> I got the impression that the exception handling was incomplete in the
> >> implementation of the function "gigaset_initcs".
> >
> > That impression is wrong. Careful reading of the code will confirm that.
> * Is it still correct nowadays that the function "gigaset_initcs" did not
> call the function "kfree" after a later function call failed?

Wrong premise. That statement was never correct.

> * Do you expect that allocated memory will be automatically reclaimed
> after it would return a null pointer?

No. Should I? Do you?


Tilman Schmidt