Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

From: Kalle Valo
Date: Tue Sep 27 2016 - 08:08:42 EST

RafaÅ MiÅecki <zajec5@xxxxxxxxx> writes:

>>>>> Kalle: this isn't important enough for 4.8 as it's too late for that.
>>>>> I'd like to get it for 4.9 however, as this fixes bug that could lead
>>>>> to WARNING on every add_key/del_key call. We was struggling with these
>>>>> WARNINGs for some time and this fixes one of two problems causing them.
>>> Ok, I'll queue this for 4.9.
>>>> Please mark it for stable as well.
>>> I can add that. Any ideas how old releases stable releases should this
>>> go to?
>> I was analyzing this.
>> 1) This patch uses brcmf_get_ifp which is available in 4.4+ only.
>> 2) It applies cleanly to 4.5+ only due to 32f90caa7debd ("brcmfmac:
>> Increase nr of supported flowrings.")
>> 3) 4.4 would also require applying to the patch without broadcom/ subdir
>> That said I suggest 4.5+. Any objections?
> Let me see if patchwork with pick Cc tag as it does for others.
> Cc: stable@xxxxxxxxxxxxxxx # 4.5+

An excellent idea but no luck:

Signed-off-by: Rafa? Mi?ecki <rafal@xxxxxxxxxx>
Acked-by: Arend van Spriel <arend@xxxxxxxxxxxx>

I'll add this to my patchwork wishlist though, I think it would be a
really useful feature to have.

(The question marks are because of my buggy copy paste, ignore those)

Kalle Valo