Re: [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show

From: David Miller
Date: Tue Sep 27 2016 - 09:46:05 EST

From: Jia He <hejianet@xxxxxxxxx>
Date: Mon, 26 Sep 2016 16:09:10 +0800

> +static int snmp_seq_show_tcp_udp(struct seq_file *seq, void *v)
> +{
> + int i;
> + unsigned long buff[TCPUDP_MIB_MAX];
> + struct net *net = seq->private;

Please always order local variables from longest to shortest
line.

Please audit your entire patch series for this problem.

Thanks.