Re: [PATCH] perf: sched-pipe add support for packet I/O mode

From: Shuah Khan
Date: Tue Sep 27 2016 - 12:38:26 EST


On 09/27/2016 05:38 AM, Peter Zijlstra wrote:
> On Mon, Sep 26, 2016 at 06:29:44PM -0600, Shuah Khan wrote:
>> Add support to run sched-pipe benchmark test on pipe with packet I/O mode.

I will add more detail here.

>>
>> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>> ---
>> tools/perf/bench/sched-pipe.c | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/tools/perf/bench/sched-pipe.c b/tools/perf/bench/sched-pipe.c
>> index 1dc2d13..c6e1b7a 100644
>> --- a/tools/perf/bench/sched-pipe.c
>> +++ b/tools/perf/bench/sched-pipe.c
>> @@ -41,9 +41,16 @@ static int loops = LOOPS_DEFAULT;
>> /* Use processes by default: */
>> static bool threaded;
>>
>> +/* Use non-packet (normal) I/O mode by default.
>> + * In packet mode, each write is a separate packet.
>> + */
>
> Also,
>
> https://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@xxxxxxxxxxxxxx
>

Bummer. I missed this comment style bad on my part. I will address both
and send v2.

thanks,
-- Shuah