Re: [PATCH 2/3] DT: EVM: add LEDs

From: H. Nikolaus Schaller
Date: Tue Sep 27 2016 - 16:10:58 EST


Hi Tony,

> Am 27.09.2016 um 21:49 schrieb Tony Lindgren <tony@xxxxxxxxxxx>:
>
> * H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> [160926 22:27]:
>> + led@6 {
>> + label = "omap5:green:led3";
>> + gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>> + };
>> +
>> + led@7 {
>> + label = "omap5:green:led4";
>> + gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>> + };
>> +
>> + led@8 {
>> + label = "omap5:green:led5";
>> + gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>> + };
>
> How about this for defaults:
>
> - heartbeat for led3
> - cpu0 for led4
> - cpu1 for led5

Good idea. Will try.

What I don't exactly know is if these gpios based on an I2C-expander
can handle cpu activity triggers or if they are locked up if this i2c
processing triggers another cpu activity...

>
> Or something along those lines that by default shows the
> active CPUs. Don't have a omap5-uevm near by right now so
> not sure about the ordering of the LEDs for displaying
> cpu0 and cpu1.

Will test tomorrow and if it works I can submit a v2.

BR and thanks,
Nikolaus