Re: [RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace
From: Greg KH
Date: Wed Sep 28 2016 - 05:27:58 EST
On Tue, Sep 27, 2016 at 04:51:49PM -0500, Zach Brown wrote:
> Adding led support for phy causes namespace conflicts for some
> phy drivers.
> The rtl871 driver declared an enum for representing LED states. The enum
> contains constant LED_OFF which conflicted with declaration found in
> linux/leds.h. LED_OFF changed to LED_STATE_OFF
> In order to avoid a possible future collision LED_ON was changed to
> LED_STATE_ON as well.
> Signed-off-by: Zach Brown <zach.brown@xxxxxx>
> drivers/staging/rtl8712/rtl8712_led.c | 388 +++++++++++++++++-----------------
> 1 file changed, 194 insertions(+), 194 deletions(-)
Ick, messy. I'll be glad to take this patch now to make your life
easier in the future.