Re: [PATCH] staging: fbtft: Fix checkpatch warning

From: Greg KH
Date: Wed Sep 28 2016 - 06:05:40 EST

Next message: Prarit Bhargava: "Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after soft remove event"
Previous message: Florian Vaussard: "Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation"
In reply to: Carlos Palminha: "[PATCH] staging: fbtft: Fix checkpatch warning"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Sep 28, 2016 at 10:59:46AM +0100, Carlos Palminha wrote:
> Improve code readability.

You are doing multiple things in the same patch, and you don't really
tell us what you are doing, or why you are doing it...

Please take a step back, relax, and wait a day before resending a patch
series for these issues.

thanks,

greg k-h

Next message: Prarit Bhargava: "Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after soft remove event"
Previous message: Florian Vaussard: "Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation"
In reply to: Carlos Palminha: "[PATCH] staging: fbtft: Fix checkpatch warning"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]