Re: [PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations

From: Paul Bolle
Date: Wed Sep 28 2016 - 07:56:26 EST

On Mon, 2016-09-26 at 17:37 +0200, SF Markus Elfring wrote:
> Some update suggestions were taken into account
> from static source code analysis.
> Markus Elfring (5):
> Â Use kmalloc_array() in two functions
> Â Improve another size determination in gigaset_initcs()
> Â Delete an error message for a failed memory allocation
> Â Release memory in gigaset_initcs() after an allocation failure
> Â Enclose two expressions for the sizeof operator by parentheses
> Âdrivers/isdn/gigaset/common.c | 31 ++++++++++++++++---------------
> Â1 file changed, 16 insertions(+), 15 deletions(-)

Two of the five patches introduced bugs. The rest of the series isn't
free of various nits either. Of course, I was in no mood to be lenient
when I looked at those three patches.

I won't take any of these patches, sorry.

Paul Bolle