Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

From: Herbert Xu
Date: Wed Sep 28 2016 - 09:10:04 EST

On Wed, Sep 28, 2016 at 09:55:58AM -0300, Marcelo Cerri wrote:
> Great! If we check the descsize every time a fallback tfm is allocated
> that should be enough to prevent bigger problems such as memory
> corruptions.

Yes a check wouldn't hurt.

> Can I move ghash_desc_ctx to a header file under include/crypto/? Or do
> you do you prefer to do that?

No you can go ahead and do the move.

> Maybe include/crypto/internal/hash.h or a new header file
> include/crypto/internal/ghash.h ?

Let's put it in include/crypto/ghash.h.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key: