Re: [PATCH 00/10] md/dm-crypt: Fine-tuning for five function implementations

[Mike Snitzer]

On Wed, Sep 28 2016 at 11:34am -0400,
SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:

> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 28 Sep 2016 17:25:17 +0200
> 
> Some update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (10):
>   Use kcalloc() in crypt_alloc_tfms()
>   Reduce the scope for a variable in crypt_alloc_tfms()
>   Rename a jump label in crypt_message()
>   Delete an unnecessary variable initialisation in crypt_message()
>   Rename a jump label in crypt_set_key()
>   Delete an unnecessary variable initialisation in crypt_set_key()
>   Rename a jump label in crypt_iv_tcw_whitening()
>   Return directly after a failed crypto_alloc_ahash() in crypt_iv_essiv_ctr()
>   Two checks and one function call less in crypt_iv_essiv_ctr() after error detection
>   Delete unnecessary variable initialisations in crypt_iv_essiv_ctr()
> 
>  drivers/md/dm-crypt.c | 51 ++++++++++++++++++++++-----------------------------
>  1 file changed, 22 insertions(+), 29 deletions(-)

These are _not_ the kind of changes I want to be seeing.  Churn in the
name of "fine-tuning".

Nack.