Re: [PATCH] HID: add missing \n to end of dev_warn messages

From: Benjamin Tissoires
Date: Wed Sep 28 2016 - 15:01:22 EST


On Sep 27 2016 or thereabouts, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Trival fix, dev_warn messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

> ---
> include/linux/hid.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 75b66ec..b2ec827 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -837,7 +837,7 @@ __u32 hid_field_extract(const struct hid_device *hid, __u8 *report,
> */
> static inline void hid_device_io_start(struct hid_device *hid) {
> if (hid->io_started) {
> - dev_warn(&hid->dev, "io already started");
> + dev_warn(&hid->dev, "io already started\n");
> return;
> }
> hid->io_started = true;
> @@ -857,7 +857,7 @@ static inline void hid_device_io_start(struct hid_device *hid) {
> */
> static inline void hid_device_io_stop(struct hid_device *hid) {
> if (!hid->io_started) {
> - dev_warn(&hid->dev, "io already stopped");
> + dev_warn(&hid->dev, "io already stopped\n");
> return;
> }
> hid->io_started = false;
> --
> 2.9.3
>