Re: [PATCH v2 7/8] media: vidc: add Makefiles and Kconfig files

From: Stanimir Varbanov
Date: Wed Sep 28 2016 - 20:56:14 EST


Hi Hans,

On 09/19/2016 01:35 PM, Hans Verkuil wrote:
> On 09/07/2016 01:37 PM, Stanimir Varbanov wrote:
>> Makefile and Kconfig files to build the video codec driver.
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
>> ---
>> drivers/media/platform/qcom/Kconfig | 8 ++++++++
>> drivers/media/platform/qcom/Makefile | 6 ++++++
>> drivers/media/platform/qcom/vidc/Makefile | 15 +++++++++++++++
>> 3 files changed, 29 insertions(+)
>> create mode 100644 drivers/media/platform/qcom/Kconfig
>> create mode 100644 drivers/media/platform/qcom/Makefile
>> create mode 100644 drivers/media/platform/qcom/vidc/Makefile
>>
>> diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig
>> new file mode 100644
>> index 000000000000..4bad5c0f68e4
>> --- /dev/null
>> +++ b/drivers/media/platform/qcom/Kconfig
>> @@ -0,0 +1,8 @@
>> +comment "Qualcomm V4L2 drivers"
>> +
>> +menuconfig QCOM_VIDC
>> + tristate "Qualcomm V4L2 encoder/decoder driver"
>> + depends on ARCH_QCOM && VIDEO_V4L2
>> + depends on IOMMU_DMA
>> + depends on QCOM_VENUS_PIL
>> + select VIDEOBUF2_DMA_SG
>
> If at all possible, please depend on COMPILE_TEST as well!

OK, I will add it.

>
> Also missing: a patch adding an entry to the MAINTAINERS file.

I will add such a patch in next submission.

--
regards,
Stan