Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero.

From: Felipe Balbi
Date: Thu Sep 29 2016 - 08:24:23 EST


Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> On Thu, Sep 29, 2016 at 02:16:44PM +0530, Manish Narani wrote:
>> This patch adds support to configure bulk maxburst through
>> module parameter. This parameter can be used to modify bulk
>> maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT
>> performance.
> Eeek, this isn't the 1990's, please don't add new module parameters :)
> We have much better ways of handling configuration options for a device,
> why not use them (configfs, sysfs files, etc.)?
> Ugh, it looks like iso_maxburst is handled this way as well.
> Felipe, why is this?

Yeah, g_zero has a few module parameters. In fact many of the gadget
drivers have them. This is all legacy stuff, pre-configfs. We can't
simply remove the legacy gadget drivers and tell everybody to start
using configfs ;-) That's what we want, no doubt.

That being said, we're not taking any new module parameters to any of
the gadget drivers OR UDC drivers. Anything new is configfs-only. Legacy
gadgets only get bug fixes.


Attachment: signature.asc
Description: PGP signature