Re: [PATCH 2/2] drm: Simplify drm_printk to reduce object size quite a bit

[Sean Paul]

On Tue, Sep 27, 2016 at 11:54 AM, Sean Paul <seanpaul@xxxxxxxxxxxx> wrote:
> On Mon, Sep 26, 2016 at 4:36 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
>> On Sun, Sep 25, 2016 at 07:18:34PM -0700, Joe Perches wrote:
>>> Remove function name and special " *ERROR*" from argument list
>>>
>>> $ size drivers/gpu/drm/built-in.o* (x86-32 defconfig, most drm selected)
>>>    text          data     bss     dec     hex filename
>>> 5635366        182579   14328 5832273  58fe51 drivers/gpu/drm/built-in.o.new
>>> 5779552        182579   14328 5976459  5b318b drivers/gpu/drm/built-in.o.old
>>>
>>> Using "%ps", __builtin_return_address(0) is the same as "%s", __func__
>>> except for static inlines, but it's more or less the same output.
>>
>> And for static inlines we more often want to know which of the many
>> callers triggered the error. We would have to play it by ear to see
>> which error messages need to be improved in cases where it not obvious
>> without the context of the static inline function name.
>>
>> Lgtm, reducing the call size for DRM_DEBUG is a definite improvement.
>> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>>
>
> Agreed on the static inlines, hopefully we won't break anyone's log
> grep workflow.
>
> I will push this to -misc in a couple days if no one objects.

Applied, thanks!

Sean


>
> Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
>
>>>
>>> Miscellanea:
>>>
>>> o Convert args... to ##__VA_ARGS__
>>> o The equivalent DRM_DEV_<FOO> macros are rarely used and not
>>>   worth conversion
>>
>> Today. I would rather see us to migrate to DRM_DEV (i.e. dev_printk) so
>> that the drm subsystem is consistent with the rest of the kernel and
>> providing the necessary information for syslog filtering.
>> -Chris
>>
>> --
>> Chris Wilson, Intel Open Source Technology Centre
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel