Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in crypt_message()

From: SF Markus Elfring
Date: Thu Sep 29 2016 - 11:44:32 EST


> In what bizzaro world is the "current Linux coding style convention"

Do you look at the evolution for a document like "CodingStyle"?


>> -
>> -error:
>> +show_warning:
>> DMWARN("unrecognised message received.");
>> return -EINVAL;
>> }
>
> "show_warning" is better than "error"

I got such an impression.


> when the net result of the goto is that the function returns -EINVAL?!?

Do other identifiers fit better for the desired description of "what" and "why"
by jump labels?


> Please give it up with these drive-by shooting of auto-generated patches.

This update step was not auto-generated.

There are further change possibilities where special analysis tools
can help in the corresponding software development.


> You're just embarassing yourself.

Do you find any of my update suggestions worth for further considerations?

Regards,
Markus